Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dask time lag tests are broken #260

Open
wtbarnes opened this issue Feb 5, 2025 · 2 comments · May be fixed by #261
Open

Dask time lag tests are broken #260

wtbarnes opened this issue Feb 5, 2025 · 2 comments · May be fixed by #261
Labels
Bug Probably a bug.

Comments

@wtbarnes
Copy link
Member

wtbarnes commented Feb 5, 2025 •
edited
Loading

Something has changed in either u.Quantity and or dask.array that is causing many of the Dask-related time lag tests to fail: https://github.com/sunpy/sunkit-image/actions/runs/13120875872/job/36606273739#step:10:309
@wtbarnes wtbarnes added the Bug Probably a bug. label Feb 5, 2025
@wtbarnes
Copy link
Member Author

wtbarnes commented Feb 5, 2025

Moving from dask==2024.12.1 to dask==2025.1.0 is what is causing the problem, I think specifically this PR: dask/dask#11611 and these lines: https://github.com/dask/dask/blob/c5524337c7abf5f9c5436736cbc8c081c193e8ab/dask/array/core.py#L215-L218. Quantity must be caught by that conditional and as such multiplication is deferred to Quantity rather Dask, resulting in eager execution.

@wtbarnes
Copy link
Member Author

wtbarnes commented Feb 5, 2025

With 2024.12.1, the following

>>> import dask.array
>>> import astropy.units as u
>>> dask.array.core._should_delegate(dask.array.from_array([1,2,3]),u.s)

returns False, but returns True with 2025.1.0.

@wtbarnes wtbarnes linked a pull request Feb 5, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Probably a bug.
Projects
None yet
Milestone
No milestone
1 participant
@wtbarnes