-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numverify requires paid tier (for HTTPS call) #1344
Comments
This was initially handled but, for some reason, removed by c18a461. We have to revert the related changes. |
Would like to take a look into this issue over this weekend if it's not already assigned. |
Hi @RyanTalbot, I'm assigning it to you. Is the context and solution clear enough ? Feel free to ask if you need help. Thank you |
Hey @sundowndev, I'm going to play around and get familiar with your project over the next few days. I think I have an decent idea of what's going on and what's needed but I will check back in once I'm more familiar with some questions. |
hey man can i ask you something?
…On Thu, Oct 26, 2023 at 3:06 AM Raphaël ***@***.***> wrote:
Hi @RyanTalbot <https://github.com/RyanTalbot>, I'm assigning it to you.
Is the context and solution clear enough ? Feel free to ask if you need
help. Thank you
—
Reply to this email directly, view it on GitHub
<#1344 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDQI7HUG2LZLKSWZLNNNEMTYBFPLFAVCNFSM6AAAAAA5AUIM3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZHA4DCOBUGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Got everything to build locally finally (npm problem) and have been able to recreate the issue. Will be diving in now for the evening. Edit: NPM issue is unrelated, but this explains it - https://x.com/t3dotgg/status/1719084819584598101?s=46&t=R3O60bEGYfPfOCdoLo6pYg |
Hey @sundowndev, was pulled onto another project when I took this on, looking to continue on with this issue now! I just want to make sure I understand the issue and what is an acceptable solution. To my understanding, the free version of the Number Verification API on APILayer covers HTTP but not HTTPS. When we attempt to verify via HTTPS, we're providing an error, which is wrong. What we should be doing here is providing a warning, or at least just not error out. On top of updating the documentation, is providing a warning in this case an acceptable solution? Only issue I'm having right now is replicating the browser example. |
Describe the bug
numverify requires paid tier (for HTTPS call), but your documentation says the free tier is acceptable:
"Go to "Number Verification API" in the marketplace, click on "Subscribe for free", then choose whatever plan you want"
https://sundowndev.github.io/phoneinfoga/getting-started/scanners/#numverify
To Reproduce
(set env var NUMVERIFY_API_KEY="my#", or use an env file)
phoneinfoga.exe scan -n 2567050000
returns
If you use a browser to verify the key, HTTP:// returns expected results, HTTPS:// returns
Expected behavior
The call should not error, or else give a warning. And the documentation should tell of this limitation.
Screenshots (optional)
Desktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: