Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with old-style sharp block #3891

Closed
pikurasa opened this issue May 14, 2024 · 0 comments
Closed

Issue with old-style sharp block #3891

pikurasa opened this issue May 14, 2024 · 0 comments
Labels

Comments

@pikurasa
Copy link
Collaborator

Description

Lilypond export and playback fails for certain projects.

After some testing, I believe it is specific to the old-style "sharp" accidental block.

Screenshots

Screenshot from 2024-05-14 10-18-23

How to Reproduce

I ran into this issue when trying to demonstrate MB's Lilypond export feature to someone. I used the Doraemon project that's in the example folder, and it wouldn't complete the save.

I believe the issue is caused by the older style of accidental blocks, and, specifically, with the sharp block (as in the image above). I tested with both the old flat and sharp blocks, and it only surfaced with the sharp block.

Console log Errors:

Uncaught TypeError: Singer.PitchActions.setSharp is not a function
    at SharpBlock.flow (PitchBlocks.js:1531:33)
    at Logo.runFromBlockNow (logo.js:1453:54)
    at logo.js:1300:32

Screenshot from 2024-05-14 10-09-06

This is a version of the Doraemon project that targets testing to a section that has the old-style sharp block:
old-style-sharp.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants