Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify TypeScript Types Failure! #375

Open
Sumit-pd opened this issue Dec 25, 2023 · 2 comments · May be fixed by #378
Open

Verify TypeScript Types Failure! #375

Sumit-pd opened this issue Dec 25, 2023 · 2 comments · May be fixed by #378

Comments

@Sumit-pd
Copy link

This issue is in context with #369
There are only documentation changes in the above pr still the verify typescript fails. The logs on my local are shown below.
sugarlabs
sugarlsb2

The Linting passes on my local, but it fails on GitHub. Here are the logs
Screenshot from 2023-12-25 10-15-44

comment: The reason for verify typescript is that _state , _defaultSynth and _polySynth from Voice.tsx are imported from singer.ts but they are not exported from singer.ts
@walterbender Take a look on this and tell me how should I proceed!
@walterbender
Copy link
Member

I think you should make them exportable as per your earlier PR (but as a separate PR). But while you are doing that you should remove the _ from the variable names as they are not internal.

@Sumit-pd Sumit-pd linked a pull request Dec 25, 2023 that will close this issue
Open
@ThisisMS11
Copy link

is this issue still relevant ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added exports Sumit-pd/musicblocks-v4
3 participants
@walterbender @Sumit-pd @ThisisMS11