feat(playground): dummy workspace inside playground #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterbender
reviewed
Feb 4, 2024
| @@ -41,7 +42,7 @@ export default class BrickBlock extends BrickModelBlock { | |||
| hasNotchInsTop: this._connectAbove, | |||
| hasNotchInsBot: this._connectBelow, | |||
| scale: this._scale, | |||
| nestLengthY: 30, | |||
| nestLengthY: params.nestLengthY ?? 17, | |||
There was a problem hiding this comment.
curious where the number 17 comes from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request Covers:
I've created a dummy workspace using the previously created bricks, custom recursive components and the tree state.
The dummy workspace state can be found here:
modules/code-builder/playground/pages/WorkSpace/data.tscoordsto properly position them inside the SVG/workspaceroute inside themodules/code-builder/playgroundapp to render the dummy workspaceHere's one screenshot:
closes #360