-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR]: use different workflows for test and release #118
Comments
I think you are saying that "most of the time I push to CI, I don't need a code signed, packaged release with all formats" and proposing that we push more of the logic to the release path (right now, tagging a version and pushing commit). I like the idea on the surface. Would the main benefit be shorted time spent in CI?
This is a big benefit — right now when people start a new template, the builds are instantly red until they configure code signing. Code signing is trivial time-wise in CI, but not developer-time-wise.... Maybe this would be a good use of CMakePresets.json — I want to add configurability without people having to constantly edit CMakeLists.txt and have trouble merging in. Couple questions I have:
|
Yes. I want the action to be finished ASAP. For people using private repos, this would reduce the cost of billing hours. I set plugin formats to the env variable and let CMake read that. if (DEFINED ENV{PLUGIN_OS_FORMAT})
set(FORMATS "$ENV{PLUGIN_OS_FORMAT}")
else ()
set(FORMATS AU VST3 Standalone)
endif ()
Reusable workflows seem to be useful. However, as we cannot pass env variables directly, we have to use
I think some plugins would have to modify a part of Pamplejuce, especially the workflow files. Therefore, I don't think dependency is a good idea. For example, I have to download signed AAX and package it with AU & VST3 to one installer in the release workflow. BTW if we make all the CMake in Pamplejuce functions/macros, we may also have to use scripts to generate https://github.com/ZL-Audio/ZLEqualizer/blob/main/packaging/packager_macOS.py https://github.com/ZL-Audio/ZLEqualizer/blob/main/packaging/packager_Windows.py |
Hi! I have just seen your post on the JUCE forum. And I think it might be a good time to make some changes to workflows.
This is related to #46. Pros and Cons of using different workflows are:
Pros:
All of these Pros can shorten the test workflow execution time. And by removing the code-signing for the test, anyone can download & run the test without modification. They can then take care of code-signing when they are ready for the release.
Cons:
The text was updated successfully, but these errors were encountered: