Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When block has large number of samples (10k+) things start to get sluggish #1

Open
sudara opened this issue Jun 23, 2021 · 2 comments
Open

When block has large number of samples (10k+) things start to get sluggish #1

sudara opened this issue Jun 23, 2021 · 2 comments

Comments

@sudara
Copy link
Owner

sudara commented Jun 23, 2021

Perhaps we can conditionally create the min/max and children.

Otherwise things get a bit unfriendly and take a few too many seconds:

evaluating
@sudara
Copy link
Owner Author

sudara commented Jun 23, 2021

min/max might be better resolved via CreateValueFromExpression, calling . findMinAndMax

@sudara
Copy link
Owner Author

sudara commented Jun 23, 2021

Should probably also just set a hard limit (4096) for channel children and the sparkline creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sudara