Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebDAV picks up files with wrong extension #266

Open
henryptung opened this issue Oct 19, 2018 · 1 comment
Open

WebDAV picks up files with wrong extension #266

henryptung opened this issue Oct 19, 2018 · 1 comment

Comments

@henryptung
Copy link
Contributor

henryptung commented Oct 19, 2018

Bug report

Steps to reproduce - current behaviour

  1. Set up WebDAV share containing passwords.kdbx
  2. Create passwords.kdbx.bak backup file as copy
  3. Link Tusk to WebDAV share
  4. Tusk picks up two databases, passwords.kdbx and passwords.kdbx.bak

What is the expected behaviour

  • Tusk picks up single passwords.kdbx database

Additional remarks

This documentation suggests Tusk should only pick up *.kdbx files, but this line pulls *.kdbx* instead, including files like a.kdbxbcdef.g. Probably should use endsWith instead?

Environment

Operating System:

Arch Linux

Browser vendor and version:

Chromium 69.0.3497.100

Storage Provider:

WebDAV

@henryptung henryptung changed the title WebDAV improperly picks up files with wrong extension WebDAV picks up files with wrong extension Oct 19, 2018
@subdavis
Copy link
Owner

Good catch.

I've come up against this enough times that I want to make file extensions configurable. Some folks may want .kdbx.bak to be visible in the same way that some misguided people insist on saving their password files as a .png

It would make sense to have a comma separated list of file extensions that Tusk can scan for.

Let's roll this issue into a feature request and fix it as part of that.

Sound good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants