add more testing

Author: subchen

app.go

@@ -47,7 +47,7 @@ type App struct {
 	OnCommandNotFound func(*Context, string)
 
 	// Handler if panic in app.Action() and command.Action()
-	OnActionPanic func(c *Context, err error)
+	OnActionPanic func(*Context, error)
 }
 
 // NewApp creates a new cli Application

app_test.go

@@ -0,0 +1,80 @@
+package cli
+
+import (
+	"testing"
+)
+
+func TestAppRun(t *testing.T) {
+	run := false
+	app := &App{
+		Action: func(ctx *Context) {
+			run = true
+		},
+	}
+
+	app.Run([]string{"app"})
+
+	if run == false {
+		t.Fatal("no app run")
+	}
+}
+
+func TestAppRunCmd(t *testing.T) {
+	run := false
+	app := &App{
+		Commands: []*Command{
+			{
+				Name: "cmd",
+				Action: func(ctx *Context) {
+					run = true
+				},
+			},
+		},
+	}
+
+	app.Run([]string{"app", "cmd"})
+
+	if run == false {
+		t.Fatal("no command run")
+	}
+}
+
+func TestAppRunCmdNotFound(t *testing.T) {
+	run := false
+	app := &App{
+		Commands: []*Command{
+			{
+				Name: "xx",
+			},
+		},
+		OnCommandNotFound: func(*Context, string) {
+			run = true
+		},
+	}
+
+	app.Run([]string{"app", "cmd", "xxx"})
+
+	if run == false {
+		t.Fatal("OnCommandNotFound not hit")
+	}
+}
+
+func TestAppRunPanic(t *testing.T) {
+	run := false
+	app := &App{
+		Action: func(ctx *Context) {
+			panic("err")
+		},
+		OnActionPanic: func(*Context, error) {
+			run = true
+		},
+	}
+
+	exit = func(int) {}
+
+	app.Run([]string{"app"})
+
+	if run == false {
+		t.Fatal("OnActionPanic not hit")
+	}
+}

context.go

@@ -7,6 +7,9 @@ import (
 	"strings"
 )
 
+// exit variable for tesing hook
+var exit = os.Exit
+
 // Context is a type that is passed through to
 // each Handler action in a cli application. Context
 // can be used to retrieve context-specific Args and
@@ -252,15 +255,15 @@ func (c *Context) ShowHelp() {
 // ShowHelpAndExit shows help and exit
 func (c *Context) ShowHelpAndExit(code int) {
 	c.ShowHelp()
-	os.Exit(code)
+	exit(code)
 }
 
 // ShowError shows error and exit(1)
 func (c *Context) ShowError(err error) {
 	w := os.Stderr
 	fmt.Fprintln(w, err)
 	fmt.Fprintln(w, fmt.Sprintf("\nRun '%s --help' for more information", c.name))
-	os.Exit(1)
+	exit(1)
 }
 
 func (c *Context) handlePanic() {
@@ -274,6 +277,6 @@ func (c *Context) handlePanic() {
 		} else {
 			os.Stderr.WriteString(fmt.Sprintf("fatal: %v\n", e))
 		}
-		os.Exit(1)
+		exit(1)
 	}
 }

context_test.go

@@ -5,7 +5,7 @@ import (
 	"testing"
 )
 
-func TestContext(t *testing.T) {
+func TestContextGet(t *testing.T) {
 	c := &Context{
 		flags: []*Flag{
 			{Name: "f1"},
@@ -84,3 +84,31 @@ func TestContext(t *testing.T) {
 		t.Errorf("f3 GetStringSlice is wrong, got: %v", got)
 	}
 }
+
+func TestContextArg(t *testing.T) {
+	c := &Context{
+		args: []string{"a", "b", "c"},
+	}
+
+	if c.NArg() != 3 {
+		t.Error("NArg() != 3")
+	}
+	if c.Arg(0) != "a" {
+		t.Error("Arg(0) != 'a'")
+	}
+	if !reflect.DeepEqual(c.Args(), c.args) {
+		t.Error("Args() is wrong")
+	}
+}
+
+func TestContextParent(t *testing.T) {
+	p := &Context{name: "p"}
+	c := &Context{parent: p}
+
+	if c.Parent().Name() != "p" {
+		t.Error("Parent() is wrong")
+	}
+	if c.Global().Name() != "p" {
+		t.Error("Global() is wrong")
+	}
+}