Skip to content

Commit

Permalink
Build/Test Tools: Avoid starting the database twice.
Browse files Browse the repository at this point in the history
The database container is started when the `services` are initially set up. Having a separate step for this sometimes introduces unexpected failures for an unknown reason.

Props johnbillion.
See #62221.

git-svn-id: https://develop.svn.wordpress.org/trunk@59402 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
desrosj committed Nov 13, 2024
1 parent a27e6a8 commit b082308
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/install-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ jobs:
#
# Performs the following steps:
# - Sets up PHP.
# - Starts the database server.
# - Downloads the specified version of WordPress.
# - Creates a `wp-config.php` file.
# - Installs WordPress.
Expand Down Expand Up @@ -157,10 +156,6 @@ jobs:
coverage: none
tools: wp-cli${{ contains( fromJSON('["5.4", "5.5"]'), matrix.php ) && ':2.4.0' || '' }}

- name: Start the database server
run: |
sudo systemctl start ${{ matrix.db-type }}
- name: Download WordPress
run: wp core download ${{ inputs.wp-version && format( '--version={0}', inputs.wp-version ) || '--version=nightly' }}

Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/reusable-upgrade-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ jobs:
#
# Performs the following steps:
# - Sets up PHP.
# - Starts the database server.
# - Downloads the specified version of WordPress.
# - Creates a `wp-config.php` file.
# - Installs WordPress.
Expand All @@ -68,7 +67,6 @@ jobs:
--entrypoint sh ${{ inputs.db-type }}:${{ inputs.db-version }}
-c "exec docker-entrypoint.sh mysqld${{ inputs.db-type == 'mysql' && contains( fromJSON('["7.2", "7.3"]'), inputs.php ) && ' --default-authentication-plugin=mysql_native_password' || '' }}"
steps:
- name: Set up PHP ${{ inputs.php }}
uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
Expand All @@ -77,10 +75,6 @@ jobs:
coverage: none
tools: wp-cli

- name: Start the database server
run: |
sudo systemctl start ${{ inputs.db-type }}
- name: Download WordPress ${{ inputs.wp }}
run: wp core download --version=${{ inputs.wp }}

Expand Down

0 comments on commit b082308

Please sign in to comment.