Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the migration graph stable? #12

Open
ThibaultLemaire opened this issue Mar 9, 2020 · 1 comment
Open

Is the migration graph stable? #12

ThibaultLemaire opened this issue Mar 9, 2020 · 1 comment
Labels
question Further information is requested

Comments

@ThibaultLemaire
Copy link

I've noticed this sentence at the very end of the README:

For now only linear revision history is supported.

I'm not sure I understand what you mean by that. We've made some tests with non-linear dependency graphs, and our migrations seem to be applied correctly.

So, is this something we should worry about, or did you just mean there's no support for squash migrations?

@ThibaultLemaire ThibaultLemaire added the question Further information is requested label Mar 9, 2020
@rooterkyberian
Copy link
Contributor

At some point I had assertion that checked if there is no more than 1 dependency in migration since I wasn't quite sure if everything was covered for them, hence the only "linear revision history" support.

As for is graph stable - execution is always dictated by name order. While there is no plan to change it I guess some new unit tests (of MigrationsGraph.__iter__ at least, including migrations with multiple dependencies) should be added before we can guarantee that this is won't change anytime in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants