Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can join club repeatedly through invites. #742

Open
randysim opened this issue Sep 8, 2023 · 3 comments
Open

User can join club repeatedly through invites. #742

randysim opened this issue Sep 8, 2023 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@randysim
Copy link
Contributor

randysim commented Sep 8, 2023

If a leader of a club gets invited to join the club on stuyactivities, they can click that invite link over and over again generating an inflated member count. To fix this, just check if the user is already in the club when adding the user.

@TheEgghead27
Copy link
Member

Note that there may be race conditions, especially in adding membership requests, due to database desync.

@TheEgghead27 TheEgghead27 added the bug Something isn't working label Sep 23, 2023
@TheEgghead27
Copy link
Member

In addition, when a bug fix is deployed, we should take care to scan for and purge extraneous memberships/requests

@TheEgghead27
Copy link
Member

Notes:

  • GraphQL API route rate-limiting for join requests and membership approvals should mitigate the race conditions.
  • Invitations must be checked for valid users
  • SQL may be used at the resolution of this bug to purge existing duplicate memberships/invitations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants