Confusing loading state in Battery Saver

[graciouselectric]

System (please complete the following information):

• OS: Android 8.1
• strongSwan version(s): 2.4.2
• Tested/confirmed with the latest version: yes

Describe the bug

I noticed that when I enable Battery Saver on Android 8.1, the indeterminate ProgressBars in the app are not properly shown. This is a known problem in Android API level <28, see e.g. this StackOverflow question. Battery Saver disables animations, also on progress bars on these versions. This is quite confusing because the loading state is not properly represented. It is fixed in later Android versions, where progress bars do appear and animate.

Looking at the code, indeterminate progress bars are created here:

className='org.strongswan.android.ui.VpnStateFragment', lineNumber=198

To fix this issue, one can check ValueAnimator.areAnimatorsEnabled() and provide a different UI element, such as a text label, when animations are disabled.

To Reproduce
Steps to reproduce the behavior:

1. Turn on Battery Saver on Android 8.1 device
2. Attempt to start VPN connection

Expected behavior
A loading indicator is shown

Actual behavior
The loading indicator is frozen

[tobiasbrunner]

Thanks for the report. This seems like a very minor issue that won't have much priority.