Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support confirmation of save LinkPaymentDetails #10041

Merged
merged 10 commits into from
Jan 30, 2025

Conversation

toluo-stripe
Copy link
Contributor

@toluo-stripe toluo-stripe commented Jan 30, 2025

Summary

LinkAccountManager usually returns LinkPaymentDetails.Saved after creating a new payment method in passthrough mode. LinkConfirmationHandler treats all payment methods as New. This PR adds supports for the Saved case

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

Sorry, something went wrong.

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │   0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │   0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │   0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.4 KiB │  90.4 KiB │ +13 B │ 170.7 KiB │ 170.7 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +13 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19975 │ 19975 │ 0 (+0 -0) 
   types │  6193 │  6193 │ 0 (+0 -0) 
 classes │  4985 │  4985 │ 0 (+0 -0) 
 methods │ 29820 │ 29820 │ 0 (+0 -0) 
  fields │ 17538 │ 17538 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3624 │ 3624 │  0
APK
    compressed    │   uncompressed   │                                           
──────────┬───────┼───────────┬──────┤                                           
 size     │ diff  │ size      │ diff │ path                                      
──────────┼───────┼───────────┼──────┼───────────────────────────────────────────
 28.5 KiB │  +7 B │  63.1 KiB │  0 B │ ∆ META-INF/CERT.SF                        
 25.4 KiB │  +4 B │    63 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
    272 B │  +1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │  +1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼───────┼───────────┼──────┼───────────────────────────────────────────
 55.3 KiB │ +13 B │ 127.4 KiB │  0 B │ (total)

@toluo-stripe toluo-stripe force-pushed the tolu/link/remove_shareable branch from 60a847e to db6e329 Compare January 30, 2025 04:21
@toluo-stripe toluo-stripe changed the title Tolu/link/remove shareable Support confirmation of save LinkPaymentDetails Jan 30, 2025
@toluo-stripe toluo-stripe marked this pull request as ready for review January 30, 2025 17:26
@toluo-stripe toluo-stripe requested review from a team as code owners January 30, 2025 17:26
@@ -21,6 +26,25 @@ internal class DefaultLinkConfirmationHandler @Inject constructor(
paymentDetails: ConsumerPaymentDetails.PaymentDetails,
linkAccount: LinkAccount,
cvc: String?
): Result {
return runCatching {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update to share this code with the fn below it? this is a lot of duplication and should be very simple to share

@toluo-stripe toluo-stripe merged commit 9839d43 into master Jan 30, 2025
13 checks passed
@toluo-stripe toluo-stripe deleted the tolu/link/remove_shareable branch January 30, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants