Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search feature does not highlight and transport to the queried text in note #1759

Open
NinjaGobbler opened this issue Jan 22, 2023 · 3 comments · May be fixed by #1797
Open

Search feature does not highlight and transport to the queried text in note #1759

NinjaGobbler opened this issue Jan 22, 2023 · 3 comments · May be fixed by #1797
Assignees
Labels

Comments

@NinjaGobbler
Copy link

What problem are you facing?

  1. I open search feature under notes, type my query text in the search bar, for example "panda" and press enter. As expected, its listing me all the notes that contain the queried text "panda", that's great.

  2. Challenge - Once I click on the desired note, then it just simply displays the note on the main pane and I don't know where in the selected note, the queried text lies. I expected it to display the note on the main pane and also directly transport me to the part of the note where the first instance of the queried text is present and show it by highlighting that part.
    image

What's the solution you'd like to see in Notesnook?

To solve this,

  1. after searching for a term "panda",
  2. as soon as I select a specific note
  3. search feature of the main pane should kick-in by prepopulating the queried term "panda" in its own search bar
    image

This way I can also see all the locations of my queried term in the currently selected note.

What alternatives have you considered?

Currently, to work this around after I search a term "panda" and select a specific note, I should again perform a Ctrl+F for the note in the main pane and type the query "panda" again to find all instances of the term in note. Which is just duplicating the search effort for every search I perform.

Additional context

No response

@alihamuh alihamuh self-assigned this Jan 24, 2023
@alihamuh
Copy link
Collaborator

#37

@pred2k
Copy link

pred2k commented Dec 22, 2023

i miss this hard. Particularly in the Android App.
Sad to see PR #1797 stuck since January.

@Filoppi
Copy link

Filoppi commented Jan 21, 2024

Is there anything stopping #1797 from being merged? It'd be great to have this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants