Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#surveyme in last Note comment should show the Note (even if there are no preceding comments) #6052

Open
mnalis opened this issue Dec 27, 2024 · 0 comments
Labels

Comments

@mnalis
Copy link
Member

mnalis commented Dec 27, 2024

Back in #2641 (via b3ad39b), it was made that #surveyme tag in the last comment would always (unless manually hidden by the user) result in showing the OSM Note, even if that comment was created by the same user which is using the app.

In SC 60.0 it works mostly, i.e. if that comment is any but the first one.

I don't think that is intentional (I see no logic for that, nor do the comments seem to indicate the reason for such strange behaviour).
If the user's last comment contains a marker indicating the survey is required and we want to display the note in that case (as we do), then it should not matter how many comments preceded that last one (0 or more).

How to Reproduce

  1. add a comment to existing note with just text test; and note gets hidden - OK
  2. add a comment to existing note with text #surveyme test; and note remains displayed - OK
  3. create a new note with text #surveyme test -- note gets hidden - BAD

Expected Behavior

  • in step (3), note should remain displayed just as in does in (2), as the last message indicates the survey is required.

Versions affected
SC 60.0, Android 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant