Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name for monuments #6042

Open
5 tasks done
Martinligabue opened this issue Dec 11, 2024 · 10 comments
Open
5 tasks done

Name for monuments #6042

Martinligabue opened this issue Dec 11, 2024 · 10 comments
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)

Comments

@Martinligabue
Copy link

Martinligabue commented Dec 11, 2024

tl:dr, exactly as board_name quest, I couldn't manage to send a push request, but I'd have tried to clone the board_name to memorial_name

General

Affected tag(s) to be modified/added: Key:monument, Key:memorial and similar
Question asked: Is there an example tag on item XY?
https://www.openstreetmap.org/node/11007296453

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by any pedestrian from the outside but a survey is necessary
  • 💤 Not an overwhelming percentage of quests have the same answer (No spam)
  • 🕓 Applies to a reasonable number of map data (Worth the effort)

Ideas for implementation

like /src/main/java/de/westnordost/streetcomplete/quests/board_name/AddBoardName.kt

eventually extended to similar pois

@matkoniecz
Copy link
Member

note: - [x] shows as nicely formatted checkbox, while - [*] does not

@westnordost
Copy link
Member

Can you do some research on this? E.g. - When should the name not be asked (because another tag is set which makes it unnecessary and/or wrong to tag a name)? How many elements are we talking about here? Can all monuments and memorials (types) expected to have a (signed) name?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Dec 12, 2024
@Vuizur
Copy link

Vuizur commented Dec 12, 2024

I think it would be important to tag it with name:signed instead of noname (compared to the information board quest). And maybe to handle multilingual names like name:en.

I don't see memorials that can't have a name, at least with a quick look through the wiki.

@westnordost
Copy link
Member

What about Stolpersteine? They are memorials FOR people, but that's not their name, right?

@Vuizur
Copy link

Vuizur commented Dec 13, 2024

The wiki says that they should generally be tagged with name=NAME_OF_PERSON, for ghost bikes it is the same. But it also says that some users use memorial:name, so objects with that tag should probably be on the "ignore list".

@westnordost
Copy link
Member

I am still unsure whether the monuments and memorials (in particular) that currently don't have a name don't in their majority have no (signed) name.... but on the other hand, it's of course difficult to ascertain that.

@westnordost westnordost added new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) and removed feedback required more info is needed, issue will be likely closed if it is not provided labels Dec 13, 2024
@Martinligabue
Copy link
Author

I'm not able to use overpass or other tools like that yet, for now I rely on the wiki, I looked through the most used tags, and, at least imo, all those that I know of have a name, for some it's not written explicitly in the wild, but they still have a name.

@matkoniecz
Copy link
Member

matkoniecz commented Dec 15, 2024

https://overpass-turbo.eu/s/1VGV finds monuments within name

you can navigate to area you know well and judge how many are actually named

and how many can be clearly surveyed

@Vuizur
Copy link

Vuizur commented Dec 15, 2024

I looked a bit into overpass (but haven't done extensive research). I think unnamed monuments are mostly mistagged memorials.

I looked into my area, there are some memorials where the name exists, but hasn't been added, but probably less than 50 percent of the results. Maybe one could ask "Does this memorial have a name?", but I'm not sure.

@Martinligabue
Copy link
Author

In every place I have knowledge of, all the monuments are actually memorials or completely wrong, maybe it could be considered to have them checked, as I didn't find a single place where they should be kept as historic=monument.
I guess this issue should only focus on the memorials, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
Development

No branches or pull requests

4 participants