Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom performance #96

Open
streamcode9 opened this issue Feb 7, 2017 · 1 comment
Open

Zoom performance #96

streamcode9 opened this issue Feb 7, 2017 · 1 comment

Comments

@streamcode9
Copy link
Owner

Revert back

function onZoom() {
	const z = event.transform.toString()
	if (z == newZoom) return

	newZoom = z
	charts.forEach(c => c.zoom(event.transform))
}
@nponeccop
Copy link
Collaborator

nponeccop commented Feb 7, 2017

C точки зрения будущей либы ревертирование является временным решением. Поскольку ретрансляция зум-событий в соседние графики будет не у всех пользователей библиотеки.

Логичнее делать это внутри c.zoom() т.е. чтобы если случайно оттранслировали лишнее, производительность не проседала

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants