You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you customise a $type variable like $hu-height-types, hu-append a list/map of per-project heights and then accidentally do it twice (for instance, by @importing the custom hu-height partial twice`, the custom classes will be generated twice.
When appending/prepending maps, this is not an issue since map-merge keeps the target if both the $source and $target contain identical keys.
While it's an edge-case (which I just ran into 😅), it could cause unnecessary confusion as to why multiple classes are output. Also, if a user accidentally overwrote 100%, for example, then their version of 100% would take precedence when hu-appending, but not when hu-prepending.
The text was updated successfully, but these errors were encountered:
stowball
changed the title
hu-append and hu-append should remove duplicates when adding to a list
hu-append and hu-prepend should remove duplicates when adding to a list
Aug 1, 2020
If you customise a
$type
variable like$hu-height-types
,hu-append
a list/map of per-project heights and then accidentally do it twice (for instance, by@import
ing the customhu-height
partial twice`, the custom classes will be generated twice.When appending/prepending maps, this is not an issue since
map-merge
keeps the target if both the$source
and$target
contain identical keys.While it's an edge-case (which I just ran into 😅), it could cause unnecessary confusion as to why multiple classes are output. Also, if a user accidentally overwrote
100%
, for example, then their version of100%
would take precedence whenhu-append
ing, but not whenhu-prepend
ing.The text was updated successfully, but these errors were encountered: