Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bunch of fixes and improvements #10

Merged
merged 27 commits into from
May 15, 2024
Merged

Bunch of fixes and improvements #10

merged 27 commits into from
May 15, 2024

Conversation

kasperpeulen
Copy link
Contributor

  • Use MSW to mock OAuth
  • use Redirect boundary for invalidation
  • use standard autoincrementing ids
  • Fix some type issues
  • Add nextjs.navigation parameters to all pages
  • Refactor auth callback to be a regular endpoint, which is easier to mock
  • Delete all other middleware as it was unused
  • Make search a regular action, to use latest next standards

@kasperpeulen kasperpeulen mentioned this pull request May 15, 2024
Closed
JReinhold
JReinhold approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨ You also tested that the application still works right?

.env.local.example Outdated Show resolved Hide resolved
app/note/[id]/page.stories.tsx Outdated Show resolved Hide resolved
@kasperpeulen
Copy link
Contributor Author

Yes, application works!

@kasperpeulen kasperpeulen merged commit e82fca8 into main May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kasperpeulen @JReinhold