Skip to content
This repository has been archived by the owner on May 28, 2019. It is now read-only.

Storybook v3 #31

Open
usulpro opened this issue Jul 15, 2017 · 6 comments
Open

Storybook v3 #31

usulpro opened this issue Jul 15, 2017 · 6 comments

Comments

@usulpro
Copy link
Member

usulpro commented Jul 15, 2017

We can switch to Storybook v3!

Is there anyone interested in this?

@usulpro
Copy link
Member Author

usulpro commented Jul 15, 2017

Todo:

  • Switch to @storybook/react

  • Use storybook-deployer

  • Switch to Jest for testing

  • Use @storybook/react/demo for demo components

@zeroasterisk
Copy link

zeroasterisk commented Jul 18, 2017

Yes - I was just about to dust off my favorite react-cdk, for a new component... but without storybook3 it makes me wonder if I should...

It is supposed to always be "updated" but the base template is already month+ behind?

Please do update so others will continue to trust this great template/dev-kit... I love it... want to keep having it around...


I just created a new cdk component, then immediately ran getstorybook to update it...

ss

@juliomenendez
Copy link

Any update on this?

@danielduan
Copy link
Contributor

@usulpro is this still something we'd like to support going forward?

I think we should either support this full on and have an active maintainer for this or deprecate this to focus other Storybook improvements.

@usulpro
Copy link
Member Author

usulpro commented Aug 28, 2017

@danielduan I'd like to pull it up to Storybook 3 level. And then integrate it somehow with getstorybook in order to fill the lack when it's running inside an empty folder. Actually, getstorybook and react-cdk use very similar templates, so it could help to maintain it. And we could share own storybook dev tools settings in order to keep it in a good fit.
(We have related work in Storybook cli by @Hypnosphi -- storybookjs/storybook#1647)

I guess this project could be useful in some narrow areas:

  • creating component libraries
  • example && test of manually configured react/storybook app

Maybe somebody who uses it can add other use cases.

On the other hand, I agree with you, we can't do anything without good maintainers team and obviously, I do not have enough time to do it only by myself. We could call the community do somebody want to help or deprecate it otherwise.

@danielduan
Copy link
Contributor

I think we should deprecate this. I don't think users lose much if they move to create-react-app + sStorybook/react

It's been months since Storybook 3 came out but there hasn't been much activity in the issues here and no PRs for the last half year.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

4 participants