Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major version upgrade guide #991

Open
1 task done
CAYdenberg opened this issue Mar 7, 2024 · 2 comments
Open
1 task done

Major version upgrade guide #991

CAYdenberg opened this issue Mar 7, 2024 · 2 comments
Labels
enhancement [Issue][PR] New feature pending-author [Issue] Add Storyblok employee pending-triage [Issue] Add labels to describe it or prioritise it

Comments

@CAYdenberg
Copy link

CAYdenberg commented Mar 7, 2024

Description

I had to bump this package to a new major version to fix a production bug (relating to hooks being called conditionally). The release notes are not very helpful in terms of highlighting what changes are considered breaking and what changes I will have to make in my code.

The upgrade made was 2.4.4 -> 3.0.4

Suggested solution or improvement

I suggest publishing a list of release notes for major versions that describe what breaking changes developers need to look out for.

Additional context

No response

Validations

@CAYdenberg CAYdenberg added enhancement [Issue][PR] New feature pending-author [Issue] Add Storyblok employee pending-triage [Issue] Add labels to describe it or prioritise it labels Mar 7, 2024
@fgiuliani
Copy link
Collaborator

Hi @CAYdenberg thanks for creating this ticket.
Did you have any issues or problems updating React SDK version to 3.0.4?

The reason for the major version bump was a dependency's major version being released:
https://github.com/storyblok/storyblok-react/releases/tag/v3.0.0

In theory, no changes would be needed on your code

@CAYdenberg
Copy link
Author

CAYdenberg commented Mar 13, 2024

No problems that I'm aware of, but it would be great if I knew how carefully to check.

If this bump was due to a major version bump in JS-SDK which was in turn due to a major version bump in js-client, which only added an additional type for export. I do not understand why the addition of a type would be considered a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [Issue][PR] New feature pending-author [Issue] Add Storyblok employee pending-triage [Issue] Add labels to describe it or prioritise it
Projects
None yet
Development

No branches or pull requests

2 participants