Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging addresses #44

Open
newhook opened this issue Nov 16, 2022 · 2 comments
Open

logging addresses #44

newhook opened this issue Nov 16, 2022 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@newhook
Copy link

newhook commented Nov 16, 2022

I'd like to log address data on both the client & the server. Is that data currently accessible?

On the server side drpc.Stream doesn't seem to expose any method to do that.

On the client side I'm logging right now by wrapping a drpcconn.Conn, and at that point the server isn't known.

@ifraixedes ifraixedes added the question Further information is requested label Nov 18, 2022
@zeebo
Copy link
Collaborator

zeebo commented Nov 18, 2022

The context returned from any stream has the transport available by using https://github.com/storj/drpc/tree/main/drpcctx#func--transport

You're not the first one to have trouble finding this. It should definitely be documented better. Do you have any suggestions on where you might expect this to be documented?

@newhook
Copy link
Author

newhook commented Dec 15, 2022

An example would have enabled me to find it I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants