Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-sass is deprecated #62

Open
borisovg opened this issue Jun 14, 2021 · 6 comments
Open

node-sass is deprecated #62

borisovg opened this issue Jun 14, 2021 · 6 comments

Comments

@borisovg
Copy link

As per node-sass README (https://github.com/sass/node-sass), the package is deprecated, with the recommendation to switch to Dart Sass package ( https://www.npmjs.com/package/sass).

@stevenschobert
Copy link
Owner

Thanks for the heads up @borisovg! We'll have to switch over soon!

@cproof
Copy link

cproof commented Dec 14, 2021

Hi @stevenschobert - do you have a timeframe on upgrading or accepting !PR64 ? With newer versions, metalsmith-sass does not work anymore due to the outdated gyp dependency of the "old" sass. Thank you!

@stevenschobert
Copy link
Owner

Hey @cproof — thanks for the reminder, and I apologize for the delay!

I just wrapped up a project that has been consuming all my free time, so I should have more time for open source going forward, and will get it merged in!

@cproof
Copy link

cproof commented Dec 15, 2021

Hi @stevenschobert ,
thank you for the update and for providing/maintaining this package at all :-)

@stevenschobert
Copy link
Owner

Hey @cproof! I just pushed out v2.0 that changes node-sass to be a peer dependency, so you should be able to pin it at any recent version you like.

I did take a look at the replacement Dart-sass project, but I didn't have enough time to invest in fully switching metalsmith-sass over to it just yet. Hopefully being able to upgrade node-sass does help for the time being.

Thanks!

@cproof
Copy link

cproof commented Jan 11, 2022

Thank you! This works perfectly 👍 (now using node-sass 6.0.1 in our build)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants