-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checker prevents adding image files to repo #44
Comments
Something I've found lately has been that the logic surrounding "only check the files that are being staged for commit" is then causing files that would otherwise be ignored to be processed. For example, pretend we're committing the following files:
Rather than running against the entire codebase, WP Enforcer would then pass those files to PHP_CodeSniffer, which can have some strange effects. Definitely something that can (and should) be addressed via the I'll dig into this, thanks for the report! |
Possibly related to #12, when I have WP Enforcer enabled, I'm prevented from adding images to my Git repo. PHPCS reports multiple errors, most noticeably "mixed line endings" and "ASP style opening tags" in the files. I have the
Internal.NoCodeFound
rule added but unless I also add an exclude-pattern for those files it still tries to check them, which is super frustrating.This happens in my theme with
screenshot.png
and some JPEG images bundled with it.The text was updated successfully, but these errors were encountered: