Highlighter toolbar is not accessible by keyboard

[gperezinf]

Describe the bug

1. Go to the Simple Demo at https://pdfviewer.net/extended-pdf-viewer/simple
2. Navigate to the highlight toolbar button with keyboard
3. Press space/enter to open the highlight popup
4. Press tab, which shifts focus to the Text toolbar button instead of the color swatches, bypassing the highlight popover

There is no way that I can see to access the color swatches or thickness slider from the highlight toolbar button when navigating the pdf viewer with keyboard only. Focusing those elements requires clicking inside the popover with a mouse and then you can navigate the options with tab as normal, but the mouse interaction is mandatory.

Additionally, when the focus is within the highlight popover (by means of clicking inside it), pressing escape on the keyboard does not close the popover.

I am not sure if this is a bug or a missing feature; but I think it's the former because the secondary toolbar, which is also a popover, is both accessible and closes on escape

Version info

• 25.6.0-rc.3

[stephanrauh]

@calixteman I've noticed that on https://mozilla.github.io/pdf.js/web/viewer.html, there's a similar bug. When you open the text editor via keyboard and hit the tab key, the focus is in the document. It should be in the editor popup. When opening the editor popup with the mouse, it behaves differently: now you can tab through the editor popup items.

And it seems you haven't implement closing the editors with the ESC key.

[stephanrauh]

@gperezinf Thanks for pointing this out! I'd like to wait for Calixteman's answer before solving your issue. I think I've found a solution that works, but I'll have to test it yet, and I want to avoid running into a merge conflict hell with pdf.js.

[stephanrauh]

I'm afraid my first attempt to solve the issue had too many side effects.

[stephanrauh]

Version 25.6.0-rc.4 fixes most of the issues you've raised. Only hitting ESC in the ink editor popup doesn't do much. Please run a test and tell me if it's an improvement.

[calixteman]

@calixteman I've noticed that on https://mozilla.github.io/pdf.js/web/viewer.html, there's a similar bug. When you open the text editor via keyboard and hit the tab key, the focus is in the document. It should be in the editor popup. When opening the editor popup with the mouse, it behaves differently: now you can tab through the editor popup items.

When opening the text editor via keyboard in toolbar, a text editor is automatically added at the center of the page it's why the focus is moved.

And it seems you haven't implement closing the editors with the ESC key.

Correct. Could you file a bug ? and I'll fix it, thank you.

[gperezinf]

Version 25.6.0-rc.4 fixes most of the issues you've raised. Only hitting ESC in the ink editor popup doesn't do much. Please run a test and tell me if it's an improvement.

It does! Now the popovers are accessible with keyboard navigation only. Thanks a lot for your work

[stephanrauh]

The final version 25.6.0 has just landed.

Todos left before closing the ticket:

• open an issue at pdf.js