Skip to content

Consider Iframe for rendering basic cards. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhicken opened this issue May 24, 2016 · 6 comments
Open

Consider Iframe for rendering basic cards. #12

jhicken opened this issue May 24, 2016 · 6 comments

Comments

@jhicken
Copy link
Contributor

jhicken commented May 24, 2016

If your component has a position fixed style. Things are ungood. If we Iframe it up we should be able to dodge that bullet.

Thoughts?

@busypeoples
Copy link
Collaborator

Sounds good.

@busypeoples
Copy link
Collaborator

@jhicken want to give it a try?

@jhicken
Copy link
Contributor Author

jhicken commented May 30, 2016

#13

There you go have a peek.

Sorry I have been aloof I want to contribute with a few more things but Im busy as of late.

@busypeoples
Copy link
Collaborator

busypeoples commented May 30, 2016

@jhicken Thanks!
@steos what do you think?

@steos
Copy link
Owner

steos commented May 30, 2016

@jhicken thanks for your work! Looks good to me, but I get a strange warning with those changes:

Warning: exception thrown by devtool while handling onSetChildren: Expected onMountComponent() to fire for the child before its parent includes it in onSetChildren().

Not sure what's the issue here, any ideas?

@jhicken
Copy link
Contributor Author

jhicken commented Jun 1, 2016

I dug into it a bit yesterday. I didn't find the cause. But I know that the test cards cause the error on first render. Also the stateful card changes make it happen. I have a guess that its related to something happening durring the translation in react-frame-component but not totally sure yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants