-
Notifications
You must be signed in to change notification settings - Fork 21
Consider Iframe for rendering basic cards. #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sounds good. |
@jhicken want to give it a try? |
There you go have a peek. Sorry I have been aloof I want to contribute with a few more things but Im busy as of late. |
@jhicken thanks for your work! Looks good to me, but I get a strange warning with those changes:
Not sure what's the issue here, any ideas? |
I dug into it a bit yesterday. I didn't find the cause. But I know that the test cards cause the error on first render. Also the stateful card changes make it happen. I have a guess that its related to something happening durring the translation in react-frame-component but not totally sure yet. |
If your component has a position fixed style. Things are ungood. If we Iframe it up we should be able to dodge that bullet.
Thoughts?
The text was updated successfully, but these errors were encountered: