finally resolve snapshot issues

Author: Fake Fake

src/Filesystem/SyncFiles/AbstractFile.php

@@ -5,6 +5,16 @@
 use Symfony\Component\Finder\Glob;
 
 class AbstractFile {
+	/**
+	 * An array of our default files.
+	 *
+	 * @var array<int, string>
+	 */
+	protected const DEFAULTS = [
+		'.distignore-defaults',
+		'.puprc-defaults'
+	];
+
 	/**
 	 * @var string
 	 */
@@ -94,12 +104,15 @@ public function writeContents( string $target_file ): string {
 
 		foreach ( $this->getPaths() as $file ) {
 			if ( ! file_exists( $this->getRoot() . $file ) ) {
-				if ( ! file_exists( $file ) || false !== strpos( $file, __PUP_DIR__ ) === false ) {
-					$is_default = true;
+				if ( ! file_exists( $file ) ) {
 					continue;
-				} else {
-					$path = $file;
 				}
+
+				if ( $this->is_default( $file ) ) {
+					$is_default = true;
+				}
+
+				$path = $file;
 			} else {
 				$path = $this->getRoot() . $file;
 			}
@@ -146,6 +159,10 @@ public function writeContents( string $target_file ): string {
 		return (string) file_get_contents( $this->getRoot() . $target_file );
 	}
 
+	public function is_default( string $file ): bool {
+		return in_array( $file, array_map( fn( $default_file ) => __PUP_DIR__ . '/' . $default_file, static::DEFAULTS ), true );
+	}
+
 	/**
 	 * Writes the file.
 	 *

tests/cli/Commands/PackageCest.php

@@ -223,10 +223,6 @@ public function it_should_package_the_zip_and_use_default_distignore_when_no_saf
 
 		$output .= $I->grabShellOutput();
 
-		$I->runShellCommand( "ls -a node_modules" );
-
-		$output .= $I->grabShellOutput();
-
 		$this->assertMatchesStringSnapshot( $output );
 	}
 

tests/cli/Commands/__snapshots__/BuildCest__it_should_run_build__0.snapshot.txt

@@ -5,6 +5,7 @@ Running build steps...
 
 .
 ..
+.pup-zip
 .puprc
 bootstrap.php
 node_modules

tests/cli/Commands/__snapshots__/PackageCest__it_should_package_the_zip_and_ignore_files_from_distignore__0.snapshot.txt

@@ -1,8 +1,5 @@
 .
 ..
-.distignore
 fake-project
-node_modules
 other-file.php
-package.json
 src

tests/cli/Commands/__snapshots__/PackageCest__it_should_package_the_zip_and_ignore_files_from_distignore_and_gitattributes__0.snapshot.txt

@@ -1,8 +1,4 @@
 .
 ..
-.distignore
-.gitattributes
 fake-project
-node_modules
-package.json
 src

tests/cli/Commands/__snapshots__/PackageCest__it_should_package_the_zip_and_use_default_distignore_when_no_safelist__0.snapshot.txt

@@ -0,0 +1,8 @@
+.
+..
+bootstrap.php
+fake-project
+src.
+..
+OtherFileWithBadVersion.php
+Plugin.php