Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing aggregator #2062

Open
yydoe08 opened this issue Aug 23, 2022 · 1 comment
Open

Changing aggregator #2062

yydoe08 opened this issue Aug 23, 2022 · 1 comment
Labels
bug Something isn't working sg-library

Comments

@yydoe08
Copy link

yydoe08 commented Aug 23, 2022

Describe the bug

Changing Aggregator in DirectedGraphSAGE gives error below

Observed behavior

if aggregator is None:
870 self._aggregator = MeanAggregator
--> 871 elif issubclass(aggregator, Layer):
872 self._aggregator = aggregator
873 else:

TypeError: issubclass() arg 1 must be a class

The error happens when changing the aggregator. I think line 871 should check the instance of aggregator and Layer or change the code to below?
issubclass(type(aggregator), Layer)

@yydoe08 yydoe08 added bug Something isn't working sg-library labels Aug 23, 2022
@lunarrecluse
Copy link

Have you imported MaxPoolingAggregator?

from stellargraph.layer import MaxPoolingAggregator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sg-library
Projects
None yet
Development

No branches or pull requests

2 participants