Not able to update custom attribute with listValues existing in assets

[bfis108137]

When I go to edit the listValues in a custom attribute (of tags/select type) that is in use on an asset it won't let me. It returns error

[bfis108137]

I found the issue but still I think it's a bug. If you have the item as null on an asset it can't be edited. I am just going to fix this on my end. I will let you guys decide.

[woyuen]

Hi @bfis108137, thanks for your feedback.

Indeed, a custom attribute with tags/select type will only allow values specified within listValues. That's by design and that's normal an error is returned.

The problem with null you mention probably comes from this line

stelace/src/services/customAttribute.js

Line 251 in 60bfbf0

const [{ count: nbAssets }] = await Asset.query().count().whereJsonNotSubsetOf(key, listValues)

where we check if the new listValues include all current usage.

An exception should probably be made for null. A fix adding it internally automatically to the list could be:

const [{ count: nbAssets }] = await Asset.query().count().whereJsonNotSubsetOf(key, _.uniqBy(listValues.concat(null)))

Would that fix your issue ?

[bfis108137]

What I am saying is that I was able to save a null value to the tags custom attribute and once I wanted to add to the list I was not able to due to the null value. Personally allowing to change the list when there are null values seems acceptable but a null exception is also an idea.