Image manipulation doesn't work with saveToS3()

[simaodiascosta]

I'm trying to use ->fit() that is documented in spatie but the output is not showing what is expected.

My code is:

$windowWidth = 2160;
$windowHeight = 3840;
$fitWidth = 1080;
$fitHeight = 1920;

BrowsershotLambda::url($url)
    ->waitUntilNetworkIdle()
    ->windowSize($windowWidth, $windowHeight)
    ->fit(Manipulations::FIT_FILL_MAX, $fitWidth, $fitHeight)
    ->setScreenshotType('jpeg', 80)
    ->saveToS3($filePath, $s3Disk);

Looking at save() in Browsershot class, I can see that applyManipulations() is called while in BrowsershotLambda saveToS3() such thing doesn't seem to exist.

Thanks for looking at this issue 👍

[stefanzweifel]

Thanks for bringing this up.
Maybe calling applyManipulations() in saveToS3() is enough, but I guess we then would need to run Imagick on Lambda? 🤔

Need to take a closer look at this over the coming days/weeks.

[simaodiascosta]

Thanks for looking into this 🙌

[stefanzweifel]

@simaodiascosta I've prepared a pull request that fixes this issue in #71.

To apply the manipulations, sidecar-browsershot will download the image from S3 to a local directory, apply the manipulations and then re-upload the image back to S3.

Would that fit into your workflow? I don''t see any other way right now to solve this. The image has to be downloaded somewhere, where PHP is executed.

[simaodiascosta]

Yes it does fit my workflow.

Really appreciate you looking at this so quickly 🙏

[stefanzweifel]

I've updated the PR to highlight in the README, that the package downloads the image in the background and does the manipulation in the background.

PR has been merged and a new version has been released: https://github.com/stefanzweifel/sidecar-browsershot/releases/tag/v1.9.0