Restore backup without database dump throw error

[scramatte]

Hi,

Restore backup without database dump throw error :

Wnx\LaravelBackupRestore\Exceptions\NoDatabaseDumpsFound 

     "No database dumps found in backup `app/only-files-2024-11-22-12-56-47.zip`."
   "Found files in db-dumps directory:"

 at vendor/wnx/laravel-backup-restore/src/Exceptions/NoDatabaseDumpsFound.php:17
    13▕     {
    14▕ 
    15▕         $files = $pendingRestore->getAvailableFilesInDbDumpsDirectory()->implode("\n");
    16▕ 
 ➜  17▕         return new static(<<<TXT
    18▕             "No database dumps found in backup `{$pendingRestore->backup}`."
    19▕             "Found files in db-dumps directory:"
    20▕             $files
    21▕         TXT

     +14 vendor frames 

 15  artisan:35
     Illuminate\Foundation\Console\Kernel::handle()

[stefanzweifel]

This is intentional. As the exception name suggests, this is thrown if no database dumps can be found.
I'm not sure what the best practice here is, but I personally like it, when I see all details when an error happens. We could obviously also catch the exception and return a non-successful status code and display the exception message in the terminal.

[shahghasiadil]

@stefanzweifel I am facing same problem we have two same instances of an application I have taken backup on windows server to s3 and then wanted to restore it in our Linux based instance I have faced exactly same problem.
Our stack: Laravel Octane, FrankenPHP, Docker

[stefanzweifel]

@shahghasiadil Are you using the latest version of the package?

There was a lengthy discussion about this in #37, where a fix has been released.

If you're running the latest version of the package to restore the backup, can you confirm the following or provide the information:

• The backup is not empty and a database dump exists.
• If you manually unzip the backup, where is the dump located?
• Has this worked before for you? Or are you a first time user of the package?

[shahghasiadil]

@stefanzweifel Hi thanks,
The backups are being taken by spatie backup and it is working on windows server, I use updated version of package.

[stefanzweifel]

@shahghasiadil ok, but can you confirm, that there is a db-dumps directory in your backup?
This package looks in this directory for dumps and throws the exception when no dump is found:
https://github.com/stefanzweifel/laravel-backup-restore/blob/main/src/PendingRestore.php#L72-L78

I don't have a Windows computer and therefore can't easily reproduce this error. On Linux there is the tree-CLI which can list all files in a directory. It would be awesome if you could provide a list of the files in your db-dumps-directory.

For example this is the output of tree bootstrap in a Laravel application on Linux.

tree bootstrap
bootstrap
├── app.php
├── cache
│   ├── packages.php
│   ├── packages.phpunit.php
│   ├── services.php
│   └── services.phpunit.php
└── providers.php

[shahghasiadil]

• it have db-dumps

[stefanzweifel]

@shahghasiadil Ok, the folder exists, but are there any files in it? How are they named?
Do the names end with extension in this code?
https://github.com/stefanzweifel/laravel-backup-restore/blob/main/src/PendingRestore.php#L80-L84

[shahghasiadil]

@stefanzweifel yes it has .sql file inside

[shahghasiadil]

@stefanzweifel this backup have db-dump inside db-dump is sql file

[stefanzweifel]

@shahghasiadil I really don't know, where the problem in the code is.

As mentioned: I can't reproduce this error as I don't own a Windows machine.

You've said, that your backup contains a db-dumps-folder and that it contains a SQL file. But you didn't share that much information besides a screenshot.
Look, I can't see what you see. To pinpoint the error, it would be awesome if you ca please confirm – with a screenshot – that your folder structure is the same? (eg. db-dumps/mysql.sql.gz)

If the folder structure is the same, it might be an issue with how the package looks for files. We already use [DIRECTORY__SEPERATOR](https://www.php.net/manual/en/dir.constants.php#constant.directory-separator) so that either / or \ is used in paths, but maybe something breaks in your system.

It would be awesome if you could try to debug this in your system.
This is the code that checks for db-dumps and files.
https://github.com/stefanzweifel/laravel-backup-restore/blob/main/src/PendingRestore.php#L50-L84

Maybe you can edit this file in your vendor folder and add some dd()-statements to figure out, what goes wrong?

---

I will try to make a release in the next few days, so that the Exception is catched by the command and that the list of files is shown in the error message. (It always seems to be cut off?)

[shahghasiadil]

@stefanzweifel I'm using Laravel Octane, FrankenPHP, Docker inside docker I have installed mysql-client which take and restore backups, MYSQL_DUMP_PATH is /usr/bin and I can take backup there is no problem in it, but when I try to restore it I'm facing the issue and backup contains db-dumps\mysql-something.sql