Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no support for description template for changelist #191

Open
tarek-vader opened this issue May 6, 2020 · 1 comment
Open

no support for description template for changelist #191

tarek-vader opened this issue May 6, 2020 · 1 comment

Comments

@tarek-vader
Copy link

we have a fixed template for a changelist description in in our perforce server, the plugin seems to override this template descrption, which is annoying.
i am getting this server error withtout the template
EnforceMinimalStandardCLDescription' validation failed
is it a bug or missing feature?? is there a way to have a template for each change list?

@mjcrouch
Copy link

mjcrouch commented May 7, 2020

What are you doing in the extension when the errors appear? Submitting a change / creating a changelist?

It sounds like you have some kind of form-out trigger on perforce that writes some stuff in the description, then the format of the description is validated when a changelist is saved / submitted?

So you would have to enter the changelist description in the same format as the template - If the template is multi-line, this means that's only possible in the source control view "Message" box, and only by doing it manually. If multi-lines are required then it wouldn't work from other locations such as when submitting the default changelist directly, (because the quick input api only allows a single line)

If I'm right - it could probably be partially supported - probably a setting could be added to enable a mode where the "Message" box is pre-populated with with the template by reading it out the default changespec - (this still wouldn't help for multi-line templates in other places though)

p.s. I currently maintain a fork of this extension - this may be merged back in soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants