Skip to content

Commit ce859d3

Browse files
authored
Update rpc errors to contain standard rpc error codes (#77)
1 parent 862eb94 commit ce859d3

File tree

1 file changed

+4
-4
lines changed
  • services/core/blueprint/key_value

1 file changed

+4
-4
lines changed

services/core/blueprint/key_value/rpc.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func (h *rpc) Set(ctx context.Context, req *connect.Request[kvv1.SetRequest]) (*
5555
_, err := h.controller.Set(log, key, value, 500*time.Millisecond)
5656
if err != nil {
5757
log.WithError(err).Error(ErrFailedSet.Error())
58-
return nil, ErrFailedSet
58+
return nil, connect.NewError(connect.CodeInternal, ErrFailedSet)
5959
}
6060

6161
log.WithField("key", key).Debug("value saved")
@@ -75,7 +75,7 @@ func (h *rpc) Get(ctx context.Context, req *connect.Request[kvv1.GetRequest]) (*
7575
value, err := h.controller.Get(log, key, value)
7676
if err != nil {
7777
log.WithError(err).Error(ErrFailedGet.Error())
78-
return nil, ErrFailedGet
78+
return nil, connect.NewError(connect.CodeNotFound, ErrFailedGet)
7979
}
8080

8181
return connect.NewResponse(&kvv1.GetResponse{
@@ -93,7 +93,7 @@ func (h *rpc) Delete(ctx context.Context, req *connect.Request[kvv1.DeleteReques
9393
err := h.controller.Delete(log, key, value)
9494
if err != nil {
9595
h.logger.WithError(err).Error(ErrFailedDelete.Error())
96-
return nil, ErrFailedDelete
96+
return nil, connect.NewError(connect.CodeInternal, ErrFailedDelete)
9797
}
9898

9999
return connect.NewResponse(&kvv1.DeleteResponse{
@@ -110,7 +110,7 @@ func (h *rpc) List(ctx context.Context, req *connect.Request[kvv1.ListRequest])
110110
valuesMap, err := h.controller.List(log, kind)
111111
if err != nil {
112112
log.WithError(err).Error(ErrFailedList.Error())
113-
return nil, ErrFailedList
113+
return nil, connect.NewError(connect.CodeNotFound, ErrFailedList)
114114
}
115115

116116
return connect.NewResponse(&kvv1.ListResponse{

0 commit comments

Comments
 (0)