Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing std::_Fake_copy_init in MSVC build #89

Open
akrzemi1 opened this issue Jan 20, 2024 · 5 comments
Open

Missing std::_Fake_copy_init in MSVC build #89

akrzemi1 opened this issue Jan 20, 2024 · 5 comments

Comments

@akrzemi1
Copy link
Contributor

I am using Microsoft Visual C++ 2022, version 17.3.4, both std C++20, and the experimental newest C++.

The compilation of std::graph::views::edges_breadth_first_search fails with an error that std::_Fake_copy_init is not defined. Removing this #ifndef guard fixes the problem. I can see that other STL implementations (like this one) do have it defined.

Maybe to enable thecompilation on any MSVC build this library should define its own type std::graph::fake_copy_init independent of the compiler used.

@pratzl
Copy link
Collaborator

pratzl commented Sep 13, 2024

Thanks for your comment. I'll consider your recommendation. I'm not sure why you're running into a problem because I've been using the latest MSVC all along.
I know it's been a while since you reported this. Do you know if you're still running into the issue?

@akrzemi1
Copy link
Contributor Author

I confirm that the bug still persists in branch master as of today: 3d572ef

I am using the same version of MSVC as in the initial report.

The error message is for this like: https://github.com/stdgraph/graph-v2/blob/master/include/graph/detail/graph_cpo.hpp#L13

My single-file test project includes two graph headers in this order:

#include <iostream>
#include <string>
#include <vector>
#include <graph/views/breadth_first_search.hpp>
#include <graph/graph.hpp>

@pratzl
Copy link
Collaborator

pratzl commented Sep 14, 2024 via email

@pratzl
Copy link
Collaborator

pratzl commented Sep 14, 2024

I'll create an independent set of definitions outside of MSVC & gcc, as you suggest. I'll try to get it in later this week.

@pratzl
Copy link
Collaborator

pratzl commented Sep 20, 2024

I've pushed a fix. I'd appreciate it if you could let me know whether it works for you or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants