Chain management #22508
Merged
Chain management #22508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clauxx
requested review from
alwx,
mohsen-ghafouri,
shivekkhurana,
smohamedjavid and
vkjr
Member
Jenkins BuildsClick to see older builds (64)
|
Contributor
Author
|
@VolodLytvynenko fixed them here already 👍 |
Member
69% of end-end tests have passedFailed tests (18)Click to expandClass TestFallbackMultipleDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletCollectibles:
Class TestWalletOneDevice:
Class TestDeepLinksOneDevice:
Class TestProfileMultipleDevices:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (6)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedThree:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Passed tests (54)Click to expandClass TestFallbackMultipleDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestAndroid13:
Class TestWalletOneDeviceThree:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestProfileOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestAndroid12:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedThree:
Class TestWalletOneDeviceTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
|
Contributor
|
@clauxx thank you for fixes. Fixed issues:
Unfortunatly one more issue is detected: |
Member
76% of end-end tests have passedFailed tests (14)Click to expandClass TestFallbackMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestProfileMultipleDevices:
Class TestWalletOneDevice:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedThree:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (5)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedThree:
Class TestCommunityOneDeviceMerged:
Passed tests (59)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDeviceThree:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletCollectibles:
Class TestWalletOneDevice:
Class TestProfileOneDevice:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedThree:
Class TestCommunityOneDeviceMerged:
Class TestFallbackMultipleDevice:
Class TestWalletOneDeviceTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestProfileMultipleDevices:
Class TestAndroid13:
Class TestAndroid12:
|
Contributor
Author
|
@VolodLytvynenko very good catch with issue 8. For some reason the router also considered non-active networks when building a route, unless we specify the non-active ones as well. Fixed in the last commit. |
Member
76% of end-end tests have passedFailed tests (13)Click to expandClass TestWalletOneDeviceThree:
Class TestProfileMultipleDevices:
Class TestDeepLinksOneDevice:
Class TestWalletCollectibles:
Class TestCommunityMultipleDeviceMergedThree:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedThree:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Passed tests (59)Click to expandClass TestAndroid12:
Class TestWalletMultipleDevice:
Class TestAndroid13:
Class TestProfileMultipleDevices:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestFallbackMultipleDevice:
Class TestWalletOneDeviceTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestProfileOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedThree:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
|
Contributor
Member
62% of end-end tests have passedFailed tests (24)Click to expandClass TestWalletCollectibles:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletMultipleDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestProfileMultipleDevices:
Class TestFallbackMultipleDevice:
Expected to fail tests (6)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedThree:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Passed tests (48)Click to expandClass TestAndroid12:
Class TestWalletOneDeviceThree:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDeviceTwo:
Class TestDeepLinksOneDevice:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedThree:
Class TestProfileOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestProfileMultipleDevices:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestFallbackMultipleDevice:
Class TestAndroid13:
|
Contributor
|
hi @clauxxthank you for the PR, and apologies for the delay in testing. I’d say this is the biggest PR I’ve worked on, that's why it took more time, I've expected One more issue has been found Users can join token-gated communities even if the token is on a deactivated network . Testing is finished from my side - network activation works well for Swap, Send, Bridge, and WalletConnect with different network combinations when enabling or disabling them. Could you help verify if the newly found issue is a blocker for merging the current PR? @shivekkhurana @churik |
Contributor
|
I think that it is not a blocker for current PR and propose to merge it and fix it separately, thanks @VolodLytvynenko |
Contributor
|
So @clauxx we are ok to merge it, thanks you for amazing work! |
Contributor
Author
Thanks, will merge it when CI is done. @VolodLytvynenko no worries, there were tons of bugs, thanks for finding them. Will look into the communities issue as a follow-up |
Member
75% of end-end tests have passedFailed tests (5)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestFallbackMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (18)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletCollectibles:
Class TestWalletMultipleDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestProfileMultipleDevices:
Class TestDeepLinksOneDevice:
|
Contributor
Contributor
Author
I think this is the intended behavior, since we don't fetch activity for disabled networks |
Contributor
Got it. If so, then txs should disappear without re-login. Now, they are disappearing only after re-login |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22301
Summary
In addition to the acceptance criteria from the issue, the following changes were added:
Areas that may be impacted
Functional
status: ready
Found Issues: