Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'apply changes' button is enabled if all checkboxes are disabled on 'edit receiver networks' drawer #19778

Closed
Tracked by #19466
VolodLytvynenko opened this issue Apr 24, 2024 · 1 comment · Fixed by #19814
Closed
Tracked by #19466

The 'apply changes' button is enabled if all checkboxes are disabled on 'edit receiver networks' drawer #19778

VolodLytvynenko opened this issue Apr 24, 2024 · 1 comment · Fixed by #19814
Assignees
@mmilad75
Labels
E:Mobile Bug MVP E:Mobile Wallet Networks and Routes low-priority

Comments

@VolodLytvynenko
Copy link
Contributor

Follow up for #19668

Steps:

  1. Open the 'edit receiver networks' drawer
  2. Uncheck all checkboxes
  3. check the 'apply changes' button

Actual result:

'apply changes' button is enabled if all checkboxes are disabled
image

Expected result:

'apply changes' button is disabled if all checkboxes are disabled

OS:

IOS, Android

Devices:

  • Pixel 7a, Android 13
  • iPhone 11 Pro Max, IOS 17

Discussed with design team :) https://discord.com/channels/624634427930312714/852533718790570015/1232291186702549002
image
@VolodLytvynenko
Copy link
Contributor Author

NOTE for QA:

take a look, at the preferable test cases https://ethstatus.testrail.net/index.php?/cases/view/730716 which can be run as sanity after the fixing of this issue

@VolodLytvynenko VolodLytvynenko mentioned this issue Apr 24, 2024
Closed
57 tasks
@mmilad75 mmilad75 self-assigned this Apr 25, 2024
@VolodLytvynenko VolodLytvynenko changed the title The 'apply changes' button is enabled in all networks are disabling in 'edit receiver networks' drawer The 'apply changes' button is enabled in all networks are disabling if 'edit receiver networks' drawer Apr 26, 2024
@mmilad75 mmilad75 mentioned this issue Apr 26, 2024
Merged
@VolodLytvynenko VolodLytvynenko changed the title The 'apply changes' button is enabled in all networks are disabling if 'edit receiver networks' drawer The 'apply changes' button is enabled if all checkboxes are disabled on 'edit receiver networks' drawer Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmilad75 mmilad75

Labels
E:Mobile Bug MVP E:Mobile Wallet Networks and Routes low-priority
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Status: Done
Milestone
No milestone
2 participants
@VolodLytvynenko @mmilad75