Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Testnet mode enabled" banner issues #19506

Closed
mariia-skrypnyk opened this issue Apr 3, 2024 · 4 comments · Fixed by #19773
Closed

"Testnet mode enabled" banner issues #19506

mariia-skrypnyk opened this issue Apr 3, 2024 · 4 comments · Fixed by #19773
Assignees
@Parveshdhull
Labels
bug ios 🔢 low prio
Milestone
2.29.0 Beta

Comments

@mariia-skrypnyk
Copy link

Bug Report

followup #19348

Problem

Expected behavior

Send button is present as designed
Screenshot 2024-04-03 at 18 23 06

Actual behavior

Screenshot 2024-04-03 at 18 21 39

Reproduction

  1. Install app
  2. Make sure you have min 1 contact
  3. Open chat with your contact
  4. Try to send any message in this chat

Additional Information
@mariia-skrypnyk mariia-skrypnyk added this to the 2.29.0 Alpha milestone Apr 3, 2024
@mariia-skrypnyk mariia-skrypnyk changed the title No Send button in chat when Testnet banner is present [iOS] No Send button in chat when Testnet banner is present Apr 3, 2024
@alwx alwx self-assigned this Apr 3, 2024
@qoqobolo
Copy link
Contributor

qoqobolo commented Apr 4, 2024

@alwx thanks for assigning the issue!
Please note that the issue also affected the following screens and buttons:

The Join community screen and the Jump to button (both iOS and Android)
Screenshot 2024-04-04 at 12 32 33

The slider in wallet when creating a new account (iOS only, probably only on small screen devices)
Screenshot 2024-04-04 at 12 33 23

@qoqobolo qoqobolo changed the title [iOS] No Send button in chat when Testnet banner is present "Testnet mode enabled" banner issues Apr 4, 2024
@alwx
Copy link
Contributor

alwx commented Apr 4, 2024

@mariia-skrypnyk perfect, thank you for the information. The PR will hopefully be ready tomorrow.

@churik churik mentioned this issue Apr 5, 2024
Closed
@alwx alwx mentioned this issue Apr 10, 2024
Closed
@seanstrom
Copy link
Member

Hey there 👋, just wanted to leave another example here of some issues with the testnet banner.

When Testnet mode is active some Legacy screens are clipped.

Screen.Recording.2024-04-08.at.11.28.31.mov

@alwx alwx mentioned this issue Apr 23, 2024
Closed
@alwx alwx removed their assignment Apr 23, 2024
@alwx
Copy link
Contributor

alwx commented Apr 23, 2024 •
edited
Loading

Please don't take this issue unless you're very sure what you're doing :) The testnet banner is disabled by this PR: #19762

@Parveshdhull Parveshdhull self-assigned this Apr 24, 2024
@Parveshdhull Parveshdhull mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Parveshdhull Parveshdhull

Labels
bug ios 🔢 low prio
Projects
None yet
Milestone
2.29.0 Beta
6 participants
@alwx @seanstrom @churik @Parveshdhull @qoqobolo @mariia-skrypnyk