Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Network Routing Visualization in Wallet Send Flow to Support Complex Connection Scenarios #19696

Closed
3 of 4 tasks
briansztamfater opened this issue Apr 17, 2024 · 0 comments · Fixed by #19768
Closed
3 of 4 tasks
Assignees
Labels
E:Mobile Wallet MVP Design system components, initial research and page wireframes

Comments

@briansztamfater
Copy link
Member

briansztamfater commented Apr 17, 2024

Problem

Currently, in status-im.contexts.wallet.send.routes.view we use the routes array returned from status-go endpoint to render cell items of Network Bridge and Network Links components. This approach won't work for some cases, for example, when the sender sends from three networks and the receiver received in two (one-to-many), because we are using a FlatList and the approach is linear (we always show a Network Bridge in the From and To columns for each item [(one-to-one)]). We may want to show a connection between one to multiple networks, and for that we need to refactor the logic and probably a list is not what we want for this case.

Example:

Acceptance Criteria

  • Do not break current UI.
  • Extend the possibilities to allow all the cases like the one on the Figma designs (one-to-many network connections).
  • If possible, create a preview screen to test different cases, because we currently depend on getSuggestedRoutes endpoint response for rendering these components and the connections.
  • Polish and refactor code in status-im.contexts.wallet.send.routes.view file which is complicated and with this new approach without FlatList should be cleaner and easier to understand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Mobile Wallet MVP Design system components, initial research and page wireframes
Development

Successfully merging a pull request may close this issue.

1 participant