Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet - Import private key flow - Add UI for Key Pair Name #18817

Closed
Tracked by #18815
J-Son89 opened this issue Feb 14, 2024 · 3 comments · Fixed by #19747
Closed
Tracked by #18815

Wallet - Import private key flow - Add UI for Key Pair Name #18817

J-Son89 opened this issue Feb 14, 2024 · 3 comments · Fixed by #19747
Assignees
Labels
E:Mobile Wallet Create Account Page MVP all issues for the create account page of the wallet feature feature requests

Comments

@J-Son89
Copy link
Member

J-Son89 commented Feb 14, 2024

Add the UI for this screen.
Designs:
https://www.figma.com/file/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?type=design&node-id=2070-595415&mode=design&t=d987JsFas3Z5NQ67-4

Screenshot 2024-02-14 at 10 49 32

This page should make use of [status-im.common.floating-button-page.view :as floating-button-page] to help with the device on smaller screens.

Connect up the re-frame data model so that the data is stored in reframe for when this page navigates to the next page - back to create account page - (the UI on that page needs some adjustment but that is a separate issue)

@J-Son89 J-Son89 added feature feature requests E:Mobile Wallet Create Account Page MVP all issues for the create account page of the wallet labels Feb 14, 2024
@J-Son89 J-Son89 self-assigned this Apr 15, 2024
@Rende11
Copy link
Collaborator

Rende11 commented Apr 15, 2024

I would like to implement it.

@J-Son89 J-Son89 assigned Rende11 and unassigned J-Son89 Apr 15, 2024
Rende11 added a commit to Rende11/status-mobile that referenced this issue Apr 20, 2024
Rende11 added a commit to Rende11/status-mobile that referenced this issue Apr 20, 2024
Rende11 added a commit to Rende11/status-mobile that referenced this issue Apr 23, 2024
Rende11 added a commit to Rende11/status-mobile that referenced this issue Apr 24, 2024
Rende11 added a commit to Rende11/status-mobile that referenced this issue Apr 25, 2024
Rende11 added a commit to Rende11/status-mobile that referenced this issue Apr 25, 2024
Move files

Fix label

Enable feature and fix auto-focus

Add events and subs
Rende11 added a commit to Rende11/status-mobile that referenced this issue Apr 30, 2024
Move files

Fix label

Enable feature and fix auto-focus

Add events and subs
Rende11 added a commit to Rende11/status-mobile that referenced this issue May 1, 2024
Move files

Fix label

Enable feature and fix auto-focus

Add events and subs
Rende11 added a commit to Rende11/status-mobile that referenced this issue May 2, 2024
Move files

Fix label

Enable feature and fix auto-focus

Add events and subs

Some fixes

Merge screens
Rende11 added a commit to Rende11/status-mobile that referenced this issue May 3, 2024
Move files

Fix label

Enable feature and fix auto-focus

Add events and subs

Some fixes

Merge screens

Fixes
Rende11 added a commit to Rende11/status-mobile that referenced this issue May 6, 2024
Move files

Fix label

Enable feature and fix auto-focus

Add events and subs

Some fixes

Merge screens

Fixes
Rende11 added a commit to Rende11/status-mobile that referenced this issue May 6, 2024
Move files

Fix label

Enable feature and fix auto-focus

Add events and subs

Some fixes

Merge screens

Fixes

Minor fixes
Rende11 added a commit to Rende11/status-mobile that referenced this issue May 7, 2024
Move files

Fix label

Enable feature and fix auto-focus

Add events and subs

Some fixes

Merge screens

Fixes

Minor fixes

Some tweaks
Rende11 added a commit to Rende11/status-mobile that referenced this issue May 8, 2024
Move files

Fix label

Enable feature and fix auto-focus

Add events and subs

Some fixes

Merge screens

Fixes

Minor fixes

Some tweaks
Rende11 added a commit to Rende11/status-mobile that referenced this issue May 8, 2024
Move files

Fix label

Enable feature and fix auto-focus

Add events and subs

Some fixes

Merge screens

Fixes

Minor fixes

Some tweaks

Fix feature flag
Rende11 added a commit to Rende11/status-mobile that referenced this issue May 8, 2024
Move files

Fix label

Enable feature and fix auto-focus

Add events and subs

Some fixes

Merge screens

Fixes

Minor fixes

Some tweaks

Fix feature flag
@OmarBasem
Copy link
Member

@J-Son89 closing this issue as we already have this screen

@J-Son89 J-Son89 reopened this May 9, 2024
@J-Son89
Copy link
Member Author

J-Son89 commented May 9, 2024

@OmarBasem - there is an open pr for this issue in progress.
It connects this page in the flow and handles some other details.
Thanks for monitoring the issues though 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Mobile Wallet Create Account Page MVP all issues for the create account page of the wallet feature feature requests
Development

Successfully merging a pull request may close this issue.

3 participants