From 11ad239b2da9adad6884c756d088de236b11931f Mon Sep 17 00:00:00 2001 From: Andy Boughton Date: Tue, 7 Dec 2021 16:52:35 -0500 Subject: [PATCH 1/5] Add some configuration and help text options to make toolbar more generic. --- src/components/GwasToolbar.vue | 13 ++++++++----- src/components/TabixAdder.vue | 7 ++++++- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src/components/GwasToolbar.vue b/src/components/GwasToolbar.vue index bf12fe6..4e418a4 100644 --- a/src/components/GwasToolbar.vue +++ b/src/components/GwasToolbar.vue @@ -22,7 +22,6 @@ export default { TabixAdder, }, props: { - // These two fields are sync bindings (this component notifies its parent of changes) genome_build: { type: String, default: 'GRCh37', @@ -37,11 +36,13 @@ export default { default: 6, }, // Track a list of studies that were added to the plot. Useful to prevent duplicates. - // TODO: move to live-binding provide/inject to support export widget / my.locuszoom.org ? known_tracks: { type: Array, default: () => [], // Each item is object of form { type, filename, display_name } }, + // Get a list of suggested entries for batch mode (useful in my.locuszoom.org, which pre-calculates top loci genome wide) + // Should fetch pre-computed top loci, and return list of [ {chr, start, end} ] entries + batch_region_getter: { type: Function, default: null }, }, data() { return { @@ -146,8 +147,6 @@ export default { @ready="receiveTabixReader" @fail="showMessage" /> - -
+ @ready="activateBatchMode"> + +
+ +
From ad2a6a70e9cbeb602f120d9810eb145b2a581f2a Mon Sep 17 00:00:00 2001 From: Andy Boughton Date: Wed, 8 Dec 2021 17:12:48 -0500 Subject: [PATCH 2/5] Include a link to instructions (in future we may want to move this to a standalone site as we create cleaner lines between the various LZ tools) --- src/App.vue | 6 ++++++ src/components/TabixAdder.vue | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/App.vue b/src/App.vue index 3cceab0..1c56e4e 100644 --- a/src/App.vue +++ b/src/App.vue @@ -42,6 +42,11 @@ export default { has_credible_sets: true, }; }, + computed: { + show_instructions() { + return window.location.hash.includes('instructions'); + }, + }, methods: { receiveTrackOptions(data_type, filename, display_name, source_configs, panel_configs, extra_plot_state) { if (!this.known_tracks.length) { @@ -95,6 +100,7 @@ export default { class="btn btn-link">Instructions
diff --git a/src/components/TabixAdder.vue b/src/components/TabixAdder.vue index 31e6630..ed30f5c 100644 --- a/src/components/TabixAdder.vue +++ b/src/components/TabixAdder.vue @@ -300,7 +300,7 @@ export default { name="data-type" value="plink_ld" > - PLINK 1.9 LD (overlay on GWAS; see guide above) + PLINK 1.9 LD (overlay on GWAS; see instructions) From 2d3fcf0df6634c5eb0fb5e9d606a1a9a2abac5b0 Mon Sep 17 00:00:00 2001 From: Andy Boughton Date: Thu, 9 Dec 2021 09:44:52 -0500 Subject: [PATCH 3/5] Add guidance for configuring cloud storage (CORS on S3, etc) --- src/App.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/App.vue b/src/App.vue index 1c56e4e..e2af526 100644 --- a/src/App.vue +++ b/src/App.vue @@ -130,7 +130,7 @@ export default {
  • If using a remote URL, the host location must support byte range requests. (how - to check) + to check) (how to configure cloud storage)
  • Your file contains all of the information required to draw a plot (see individual file format instructions for details).
    • From 6c93a118d08a0adeaee27899b5a9830623bd3ca6 Mon Sep 17 00:00:00 2001 From: Andy Boughton Date: Thu, 9 Dec 2021 17:01:18 -0500 Subject: [PATCH 4/5] Wording tweaks for remote hosts --- src/App.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/App.vue b/src/App.vue index e2af526..d893f76 100644 --- a/src/App.vue +++ b/src/App.vue @@ -128,7 +128,7 @@ export default {
  • The data is hosted in a place that is reachable by web browser (eg local files or a service such as S3)
    • -
  • If using a remote URL, the host location must support byte range requests. (If using a remote URL, the host location must support cross-origin byte range requests. (how to check) (how to configure cloud storage)
    • From bf3a62077a73ece04031b8e30f213f3598d4331c Mon Sep 17 00:00:00 2001 From: Andy Boughton Date: Fri, 10 Dec 2021 15:18:59 -0500 Subject: [PATCH 5/5] Bump version 0.9.3 with improved instructions + better my.lz.org reusability --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index ef0deff..78ba7b6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "localzoom", - "version": "0.9.2", + "version": "0.9.3", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 040196b..f536cc8 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "localzoom", - "version": "0.9.2", + "version": "0.9.3", "license": "MIT", "engines": { "node": ">=10.13.0"