Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop a more in-depth integration test for the TS rpc client #1806

Open
geoknee opened this issue Oct 4, 2023 · 0 comments
Open

Develop a more in-depth integration test for the TS rpc client #1806

geoknee opened this issue Oct 4, 2023 · 0 comments

Comments

@geoknee
Copy link
Contributor

geoknee commented Oct 4, 2023

Currently, we spin up a number of rpc servers, and use the client-runner ts-node script to drive them.

A better solution would be to write a jest test to replace the ts-node script.

It should follow https://github.com/statechannels/go-nitro/blob/e8451e1a633a490056dbb9d2b047a32f263ec75a/node_test/rpc_test.go in terms of what it looks to cover.

It should be kept separate from unit tests (i.e. a separate script in the package manifest, possibly a separate jest config)

It may want to pull in some of the isServerUp helpers from the client runner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geoknee