Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple VirtualFund protocol from PaymentChannel in the engine #1750

Open
NiloCK opened this issue Sep 19, 2023 · 0 comments
Open

Decouple VirtualFund protocol from PaymentChannel in the engine #1750

NiloCK opened this issue Sep 19, 2023 · 0 comments
Labels
💰 payments Work around enabling payments in the nitro client tech-debt

Comments

@NiloCK
Copy link
Contributor

NiloCK commented Sep 19, 2023

Go-nitro node currently assumes (eg, here) that all virtual fund objectives are for the Virtual Payment App.

Possible path to decoupling is to inspect the AppDefinition value associated with the VFO's target channel, and execute PaymentChannelApp logic if the (a?) correct address is found.
@NiloCK NiloCK added 💰 payments Work around enabling payments in the nitro client tech-debt labels Sep 19, 2023
NiloCK pushed a commit that referenced this issue Sep 20, 2023
emit request to register payment channel post VFO
5ead561 
... this is overly specified - see
github.com//issues/1750
@NiloCK NiloCK mentioned this issue Sep 20, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💰 payments Work around enabling payments in the nitro client tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NiloCK