Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow batched deposits into single channel #1710

Open
NiloCK opened this issue Sep 14, 2023 · 0 comments
Open

Allow batched deposits into single channel #1710

NiloCK opened this issue Sep 14, 2023 · 0 comments

Comments

@NiloCK
Copy link
Contributor

NiloCK commented Sep 14, 2023

Per discussion w/ @nksazonov and others, some channels may want to manage several types of assets simultaneously. Performing a separate deposit transaction for each asset is inefficient.

#1574 introduced batch deposits of either ETH or a single ERC20 into many channels simultaneously via a proxy BatchOperator contract. The same approach will not work in this case, because each individual ERC20 token would require its own

Plan / recommendation: implement a depositAssetBatch function directly on MultiAssetHolder. The implementation can follow the pattern established in BatchOperator - just receive arrays of data that will be forwarded into the existing deposit function.

Might also be nice to have some gas benchmarks to compare an n-ERC20 token deposit against n calls to deposit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant