-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use term supported in channel struct #1596
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently channel struct assumes a supported state is a unanimously signed state. However this isn't strictly true, it depends on the specific
ForceMove
app rules that define what a supported state is.For example, with the
Virtual Payment App
a state with turnNum=2 is supported if it is signed by Bob and contains a signed voucher from Alice.This doesn't really cause a problem for us because we're only really using the channel struct for setup or finalizing a channel, which does require unanimous consent. However it does mean we're overloading the term
supported
and making things harder to understand.To address this I propose that instead of using the term
Supported
to refer to a fully signed state, we just useFullySigned
orUnanimousConsensus
.Perhaps longer term we could consider emulating the EVM and actually calling stateIsSupported but I think that would be overkill at the moment.
The text was updated successfully, but these errors were encountered: