Skip to content

Commit 0da4b3f

Browse files
committed
bool processing fixes
1 parent 54fde81 commit 0da4b3f

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

files/etc/init.d/https-dns-proxy

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -184,14 +184,14 @@ append_boot() {
184184
[ -z "$_loctmp" ] && return 0
185185
IFS=" ,"
186186
for i in $_loctmp; do
187-
if { [ "$force_ipv6" -eq 0 ] && is_ipv4 "$i"; } || \
188-
{ [ "$force_ipv6" -ne 0 ] && is_ipv6 "$i"; }; then
187+
if { [ -z "$force_ipv6" ] && is_ipv4 "$i"; } || \
188+
{ [ -z "$force_ipv6" ] && is_ipv6 "$i"; }; then
189189
[ -z "$_newtmp" ] && _newtmp="$i" || _newtmp="${_newtmp},${i}"
190190
fi
191191
done
192192
IFS="$_old_ifs"
193193
[ -n "$_newtmp" ] && xappend "$switch $_newtmp"
194-
[ "$force_ipv6" -eq 0 ] && xappend '-4'
194+
[ -z "$force_ipv6" ] && xappend '-4'
195195
}
196196

197197
boot() {
@@ -240,6 +240,7 @@ start_instance() {
240240
config_get listen_addr "$cfg" 'listen_addr' "$global_listen_addr"
241241
config_get listen_port "$cfg" 'listen_port' "$port"
242242
config_get_bool force_ipv6 "$cfg" 'force_ipv6_resolvers' "$global_force_ipv6"
243+
[ "$force_ipv6" = '1' ] || unset force_ipv6
243244

244245
append_parm "$cfg" 'resolver_url' '-r'
245246
append_parm "$cfg" 'listen_addr' '-a' "$global_listen_addr" '127.0.0.1'
@@ -367,16 +368,16 @@ start_service() {
367368
stop_service() {
368369
local param="$1"
369370
local canaryDomains
370-
local s=0
371+
local _error=
371372
output "Stopping $serviceName ${param:+$param }"
372373
load_package_config "$param"
373374
dhcp_backup 'restore'
374375
if uci_changes 'dhcp'; then
375376
uci_commit 'dhcp'
376-
dnsmasq_restart || s=1
377+
dnsmasq_restart || _error=1
377378
fi
378379
# shellcheck disable=SC2015
379-
[ "$s" = '0' ] && output_okn || output_failn
380+
[ -z "$_error" ] && output_okn || output_failn
380381
}
381382

382383
# shellcheck disable=SC2015

0 commit comments

Comments
 (0)