-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: eslint-config-standard-with-typescript to depart from standard #1957
Comments
This makes sense to me. As I have been following things lately I have noticed this is the central tension in the project so I am glad to see there is a way everyone can get what they need/want out of it. |
I'm 👍 on this, thanks for suggesting 🙏 There are some practicalities to it I guess, so lets sync up on those so that we are all on the same page as to what this would entail. This is what I'm personally thinking of, from the top of my mind:
Any other practicalities I'm missing? Any other modules or npm-packages that would need to be moved? Also: Would the new org still rely on |
The latter. Otherwise, sounds good. |
@rostislav-simonik and I would like to implement this RFC (depart eslint-config-standard-with-typescript from @standard). We find it reasonable at this point to announce our intention to implement this RFC after a certain future date: 2024-01-12. DMs will be sent to @feross and @mcollina. |
I'm ok with it, +1. |
The new home is https://github.com/mightyiam/eslint-config-standard-with-typescript . |
Could someone please make me owner of the eslint-config-standard-with-typescript npm package? @voxpelli perhaps? |
My npm username is mightyiam. |
Sorry for the delay here. Ok I removed the package Does that look right to everyone? |
@bcomnes thank you. If the 'maintainer' role means full control, then that seems complete. Could you, perhaps do the same for ts-standard? |
@mightyiam I tried adding you as a maintainer/collaborator on that package on npm but get a forbidden error. As an admin I am unable to invite you back to the org. |
@bcomnes Essentially we should do the same thing with |
The difference here's that he's no longer on the package as a collaborator, and I'm unable to add outside collaborators as an admin. I think only owners can do this. |
@bcomnes a problem on both npm and GitHub or just npm? |
Npm |
@mightyiam Is this still of interest to solve? If so: Reminder @feross. Else we can close this? |
ts-standard probably belongs together with eslint-config-standard-with-typescript. |
The governance of eslint-config-standard and -with-typescript is unclear and causing trouble for this project. This patch pulls in the relevant code from -with-standard as a first step towards fully owning the ESLint configuration. A follow-up patch is planned to do the same for eslint-config-standard. By doing this, we are able to upgrade `@typescript-eslint/eslint-plugin` from v6 to v7, which is the current latest version. Refs: standard/standard#1948 Refs: standard/standard#1957
…195) The governance of eslint-config-standard and -with-typescript is unclear and causing trouble for this project. This patch pulls in the relevant code from -with-standard as a first step towards fully owning the ESLint configuration. A follow-up patch is planned to do the same for eslint-config-standard. By doing this, we are able to upgrade `@typescript-eslint/eslint-plugin` from v6 to v7, which is the current latest version. Refs: standard/standard#1948 Refs: standard/standard#1957
Background
eslint-config-standard-with-typescript (-with-typescript) was first published September 2017. Two years later, August 2019, the repository was transferred into the standard organization. We have enjoyed and appreciate the contributions by various members of the community, yet, I and later @rostislav-simonik and @jay-bulk have been the regular contributors since.
Popularity of -with-typescript has been on the rise since the beginning of 2020, with a significant increase in adoption rate since July 2022, which is about the time the mob was formed.
Policy discrepancy
Standard always had a certain approach with regards to the scope and impact of rules and the frequency of releases. And -with-typescript always had quite a different approach. For example, -with-typescript wasn't shy in making frequent major releases that introduced new rules. The reasoning has been that of continuous delivery, semantic commits/releases and the idea that users would be able to bump the version at their own pace.
Suggested solution
-with-typescript will depart from its dependency on eslint-config-standard and therefore depart from its relationship with Standard. This would permit -with-typescript the freedom to introduce such changes that would currently be incompatible with standard. For example, new core ESLint (non-TypeScript) rule.
Of course, We will continue to welcome asynchronous contributions from outside the regular mob sessions.
Co-authored-by: @rostislav-simonik
The text was updated successfully, but these errors were encountered: