refactor(layer-categories): fetch layer categories from external service #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbruch
requested changes
Feb 1, 2025
|
|
||
| const context = dispatcher.getContext(); | ||
|
|
||
| fetch(context.config.layerCategoriesUrl) |
There was a problem hiding this comment.
This will break for other stadtnavi instances, no? I think we should fall back to a minimal default config here. Let's discuss how it should like
There was a problem hiding this comment.
No this won't break other instances, because they are not using external provided layer config at all.
andreashelms
force-pushed
the
refactor/fetch-external-layer-categories
branch
from
b511c39 to
f84fc3e
Compare
andreashelms
force-pushed
the
refactor/fetch-external-layer-categories
branch
from
f84fc3e to
6f38a23
Compare
hbruch
requested changes
Feb 6, 2025
andreashelms
force-pushed
the
refactor/fetch-external-layer-categories
branch
from
829e986 to
09f7af6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #902