Change behavior when miner times out waiting for block acceptance/rejection #5856
Assignees
Milestone
Comments
|
The scenarios where this is necessary also highlight the need to begin punishing non-responsive signers so that they are incentivized to remain responsive. This scenario is happening more often than it should. |
|
Note: this also requires an update on the signer side to re-consider the block when it receives the new proposal. |
obycode
added a commit
that referenced
this issue
Feb 28, 2025
When a miner times out waiting for signatures, instead of proposing a new block, it should only re-propose the same block. Proposing a new block is guaranteed to fail because signers that approved the original block will reject any new block at the same height. This implements the miner side of #5856. A change is still needed on the signer side to allow a signer to accept a block that it previously rejected.
obycode
added a commit
that referenced
this issue
Feb 28, 2025
Allows a signer to reconsider a block that it previously rejected if it was rejected for certain reasons that may resolve themselves, for example a testing directive, the parent block was unknown, or there was a communication failure with the stacks-node. Resolves #5856
obycode
added a commit
that referenced
this issue
Mar 3, 2025
Allows a signer to reconsider a block that it previously rejected if it was rejected for certain reasons that may resolve themselves, for example a testing directive, the parent block was unknown, or there was a communication failure with the stacks-node. Resolves #5856
obycode
added a commit
that referenced
this issue
Mar 3, 2025
Allows a signer to reconsider a block that it previously rejected if it was rejected for certain reasons that may resolve themselves, for example a testing directive, the parent block was unknown, or there was a communication failure with the stacks-node. Resolves #5856
obycode
added a commit
that referenced
this issue
Mar 3, 2025
Allows a signer to reconsider a block that it previously rejected if it was rejected for certain reasons that may resolve themselves, for example a testing directive, the parent block was unknown, or there was a communication failure with the stacks-node. Resolves #5856
obycode
added a commit
that referenced
this issue
Mar 4, 2025
Allows a signer to reconsider a block that it previously rejected if it was rejected for certain reasons that may resolve themselves, for example a testing directive, the parent block was unknown, or there was a communication failure with the stacks-node. Resolves #5856
obycode
added a commit
that referenced
this issue
Mar 4, 2025
Allows a signer to reconsider a block that it previously rejected if it was rejected for certain reasons that may resolve themselves, for example a testing directive, the parent block was unknown, or there was a communication failure with the stacks-node. Resolves #5856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the miner has a timeout when waiting for a block to be approved or rejected. When that timeout is reached, it essentially gives up on that block and proposes a new block. This new proposal will be guaranteed to be rejected by any signers that accepted the block initially proposed, so this is not helpful. It would be better for the miner to simply re-proposed the same block, just in case that somehow helps reach a signer which did not respond to the previous proposal.
See #5847 for background discussion.
The text was updated successfully, but these errors were encountered: