Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Set the output index in SweptWithdrawalRequests #1454

Open
1 task
djordon opened this issue Mar 3, 2025 · 0 comments · May be fixed by #1475
Open
1 task

[Bug]: Set the output index in SweptWithdrawalRequests #1454

djordon opened this issue Mar 3, 2025 · 0 comments · May be fixed by #1475
Assignees
Labels
sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation.

Comments

@djordon
Copy link
Collaborator

djordon commented Mar 3, 2025

Bug - Set the output index in SweptWithdrawalRequests

1. Description

Right now the output index sent in accept-withdrawal-request contract calls is fixed at 2. We have the correct data in the database, we just need to set it correctly when making the contract call.

1.1 Context & Purpose

The contract call data is potentially used by users or services to properly verify that a withdrawal has been fulfilled. We should make sure that it gets set correctly.

2. Technical Details:

The contract call gets populated with data from a SweptWithdrawalRequest object, which itself gets created with the output of a query. We need to update the SweptWithdrawalRequest struct to have an output_index field and also the query to correctly populate the new field from the bitcoin_withdrawals_outputs table. Then we need to set the vout field in the returned OutPoint when calling SweptWithdrawalRequest::to_withdrawal_outpoint.

2.1 Acceptance Criteria:

  • SweptWithdrawalRequest::to_withdrawal_outpoint creates the correct outpoint for the withdrawal request.

3. Related Issues and Pull Requests (optional):

@djordon djordon added sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation. labels Mar 3, 2025
@djordon djordon added this to the sBTC: Withdrawal fine tuning milestone Mar 3, 2025
@djordon djordon added this to sBTC Mar 3, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Mar 3, 2025
@djordon djordon moved this from Needs Triage to Todo in sBTC Mar 3, 2025
@MCJOHN974 MCJOHN974 linked a pull request Mar 5, 2025 that will close this issue
4 tasks
@djordon djordon moved this from Todo to In Review in sBTC Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation.
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

2 participants